Skip to content

fix(history): reject fractional page sizes#55

Open
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/history-page-size-integer
Open

fix(history): reject fractional page sizes#55
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/history-page-size-integer

Conversation

@JerryNee

Copy link
Copy Markdown

Summary

  • make test result --history --page-size reject fractional values before building the request
  • keep the existing 1-100 bounds check, but add an integer check for values such as 1.5
  • add regression coverage that ensures no request is made for a fractional history page size

Repro

Before this change, testsprite test result test_abc --history --dry-run --page-size 1.5 --output json exited 0 and passed the fractional page size through. After this change it exits 5 with a local VALIDATION_ERROR naming page-size.

Verification

  • npm test -- src/commands/test.result.history.spec.ts
  • npm run typecheck
  • npm run lint
  • npm test
  • npm run build
  • node dist/index.js --output json test result test_abc --history --dry-run --page-size 1.5

@zeshi-du

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zeshi-du, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 699ccfb7-4f44-42bf-9555-f8b65ebd538d

📥 Commits

Reviewing files that changed from the base of the PR and between 15e95de and ebfb5a4.

📒 Files selected for processing (2)
  • src/commands/test.result.history.spec.ts
  • src/commands/test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants